Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop node@14 #363

Merged
merged 7 commits into from
Sep 16, 2023
Merged

feat: drop node@14 #363

merged 7 commits into from
Sep 16, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 15, 2023

14.x reached EOL on 2023-04-30 https://github.com/nodejs/Release

This is normally considered semver major but since we haven't hit 1.0.0, this is semver minor.

I also added node@20 to CI but had to remove @tensorflow/tfjs-node since it didn't work.

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@styfle styfle changed the title BREAKING CHANGE: drop node@14 feat: drop node@14 Sep 15, 2023
@styfle styfle marked this pull request as ready for review September 16, 2023 03:11
@styfle styfle requested a review from ijjk as a code owner September 16, 2023 03:11
@styfle styfle requested a review from cb1kenobi September 16, 2023 03:12
@styfle styfle enabled auto-merge (squash) September 16, 2023 03:12
@styfle styfle requested a review from TooTallNate September 16, 2023 03:24
@styfle styfle merged commit 712fee2 into main Sep 16, 2023
19 checks passed
@styfle styfle deleted the drop-node-14 branch September 16, 2023 07:19
@github-actions
Copy link

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ijjk ijjk mentioned this pull request Dec 2, 2023
Ethan-Arrowood pushed a commit that referenced this pull request Dec 13, 2023
16.x reached EOL 2023-09-11
[nodejs/Release](https://github.com/nodejs/Release#:~:text=2021%2D06%2D01-,16.x,-End%2Dof%2DLife)

Similar to #363 since we haven't
reached v1.0.0 yet this isn't considered a semver major bump.

Co-authored-by: Ethan Arrowood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants