Skip to content

Remove vtr::string_view #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2025
Merged

Remove vtr::string_view #3280

merged 4 commits into from
Sep 24, 2025

Conversation

soheilshahrouz
Copy link
Contributor

Removes vtr::string_view class. All instances are replaced with std::string_view.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions docs Documentation lang-cpp C/C++ code libvtrutil labels Sep 24, 2025
AmirhosseinPoolad
AmirhosseinPoolad reviewed Sep 24, 2025
View reviewed changes
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests pass other than some minor comments.

@soheilshahrouz soheilshahrouz changed the title [WIP] Remove vtr::string_view Remove vtr::string_view Sep 24, 2025
@soheilshahrouz soheilshahrouz merged commit 80e9734 into master Sep 24, 2025
30 checks passed
@soheilshahrouz soheilshahrouz deleted the remove_vtr_string_view branch September 24, 2025 22:23
@soheilshahrouz soheilshahrouz mentioned this pull request Sep 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmirhosseinPoolad AmirhosseinPoolad AmirhosseinPoolad left review comments

Assignees
No one assigned
Labels
docs Documentation lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions libvtrutil VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soheilshahrouz @AmirhosseinPoolad