fix: basePath option name should align with Astro base option name (#46)
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vernak2539
force-pushed
the
fix/rename-basepath-option
branch
from
e39891b to
975a7cb
Compare
|
I've removed the generated docs update, as i've now added an automation for this when things are merged to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT - This PR contains the fixes in #55 so should be merged after it.
❗ IMPORTANT: Breaking Change❗
If I'm understanding the way github-changelog-generator works, adding a label named
Breaking changes:to this PR and/or issue #46 should annotate the generated changelog with the information about the breaking change. Alternatively, it looks like adding a labelbreakingto issue #46 would do the same thing so either way "should" work.Resolves #46