Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests with ASAN to node CI #1415

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

satoren
Copy link
Contributor

@satoren satoren commented Jun 28, 2024

No description provided.

Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I have questions.

.github/workflows/mediasoup-node.yaml Show resolved Hide resolved
.github/workflows/mediasoup-node.yaml Show resolved Hide resolved
@ibc ibc mentioned this pull request Jun 28, 2024
@@ -11,12 +11,22 @@ concurrency:
jobs:
ci:
strategy:
fail-fast: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is good while writing a PR we prefer not to have this once merged so I will remove this once we merge this PR.

@ibc ibc merged commit 4ef1161 into versatica:v3 Jul 1, 2024
41 checks passed
@ibc
Copy link
Member

ibc commented Jul 1, 2024

@satoren wanna help in this similar PR for worker tests? #1416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants