Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests with ASAN to node CI #1415

Merged
merged 1 commit into from
Jul 1, 2024
Merged

add tests with ASAN to node CI #1415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/mediasoup-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,22 @@ concurrency:
jobs:
ci:
strategy:
fail-fast: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is good while writing a PR we prefer not to have this once merged so I will remove this once we merge this PR.

matrix:
ci:
- os: ubuntu-20.04
node: 18
- os: ubuntu-22.04
node: 20
- os: ubuntu-24.04
node: 20
meson_args: '-Db_sanitize=address'
- os: ubuntu-24.04
node: 20
meson_args: '-Db_sanitize=undefined'
ibc marked this conversation as resolved.
Show resolved Hide resolved
- os: ubuntu-24.04
node: 20
meson_args: '-Db_sanitize=thread'
ibc marked this conversation as resolved.
Show resolved Hide resolved
- os: macos-12
node: 18
- os: macos-14
Expand All @@ -33,6 +43,7 @@ jobs:
MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: 'true'
MEDIASOUP_LOCAL_DEV: 'true'
MEDIASOUP_BUILDTYPE: ${{ matrix.build-type }}
MESON_ARGS: ${{ matrix.ci.meson_args }}

steps:
- name: Checkout
Expand All @@ -54,6 +65,8 @@ jobs:

- name: npm ci
run: npm ci --foreground-scripts
env:
ASAN_OPTIONS: 'detect_leaks=0' # Disable leak detection because it is detected by the tool flatc used to build

- name: npm run lint:node
run: npm run lint:node
Expand Down
Loading