Improve Region Dropdown Selections #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnovak
requested changes
Dec 4, 2023
There was a problem hiding this comment.
This looks good and seems to work properly when I run it, except I don't like the implementation of getting rid of the none: option. We're filtering it out instead of working out why it is getting generated and making that not happen.
Also the PR probably needs to be updated with the merge of the other region dropdown PR.
src/components/RegionInput.js
Outdated
| } | ||
|
|
||
| // Autocomplete selectable options | ||
| const displayRegions = [...pathsWithRegion, ...pathNamesColon]; | ||
| const displayRegions = [...pathsWithRegion, ...pathNamesColon].filter(option => option.label !== "none:"); |
There was a problem hiding this comment.
I don't think this is the Right Way to get rid of this extra option, because the code does not convince me that we actually know why it is showing up.
Either we should get rid of it where it is actually being generated, or we should have a comment here explaining why it is there and why this actually is the best time to remove it.
adamnovak
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use label system to display both path with region and description while ignoring description upon onChange
Closes #362