Implement highlightable description #380
Conversation
There was a problem hiding this comment.
It looks like this should work. I think the extra argument to handleRegionChange is the wrong way to do it, but I think to do it the right way it has to be coordinated with @shreyasun and what she ends up doing for the left/right button work.
| if (regionObject) { | ||
| regionValue = regionObject.value | ||
| } | ||
| handleRegionChange(regionValue, regionToDesc.get(regionValue)); |
There was a problem hiding this comment.
I feel like the regionToDesc lookup might really want to be in handleRegionChange? So it doesn't need a new argument? But we kind of maintain the whole database of regions in RegionInput and it would be odd to do it twice.
I think Shreya is working on the left/right button jump-to-next-region thing in #354 though and that requires having more of an understanding of the region database in the header form, so I think this sort of thing is moving out of RegionInput in the medium term.
|
Here's a screenshot of the text on the page, under the go button, with its heading: It's tied to what region you have selected/typed, not to what region is currently displayed, which might be a little confusing? But it's probably fine. |
Puts Description, if available, as text below Go button.
Closes #378