RSDK-4952 - pass priority attribute #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
viambot
added
safe to test
|
viamrobotics/viam-typescript-sdk#181 (comment) This comment actually applies to this PR more than the one I posted it on 🙂 |
Done! |
maximpertsov
suggested changes
Oct 25, 2023
Co-authored-by: Maxim Pertsov <[email protected]>
viambot
added
safe to test
maximpertsov
approved these changes
Oct 25, 2023
viambot
added
safe to test
cheukt
requested changes
Oct 25, 2023
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
cheukt
approved these changes
Oct 26, 2023
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related TS SDK change
Jira ticket
Allowing for a custom priority attribute to be pushed in.
Tested with a board running the MicroRDK to confirm default and customized priority works as expected. Also tested with a robot running the regular RDK (with and without a priority attribute) to confirm everything else still works. The echo example was also run to confirm it ran smoothly.