RSDK-5228 - allow setting sdp values #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's okay - I'm more concerned with the goutils side of the change since the JS code has zero test coverage. It seems like you did sufficient manual testing there though. It might be a good idea to run the echo example in that repo to ensure all of the different gRPC over webrtc calls still work. |
DTCurrie
reviewed
Oct 25, 2023
maximpertsov
approved these changes
Oct 27, 2023
cheukt
requested changes
Oct 27, 2023
cheukt
approved these changes
Oct 27, 2023
purplenicole730
requested review from
DTCurrie,
maximpertsov and
micheal-parks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related goutils change
Jira ticket
Allowing for a custom priority attribute to be pushed in.
Tested with a board running the MicroRDK to confirm default and customized priority works as expected. Also tested with a robot running the regular RDK (with and without a priority attribute) to confirm everything else still works.
NOTE: The
build_lint_testerror seems to be caused by goutils, and should be solved with the goutils change linked above.How could we test this, or is it okay not to add tests for this?