RSDK-8017: linting action #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaney
approved these changes
Jul 12, 2024
dhritinaidu
changed the title
bhaney
reviewed
Jul 18, 2024
.github/workflows/golangci-lint.yml
Outdated
| buildvcs: false | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.15 |
There was a problem hiding this comment.
this go version is too low -- we are on go version 1.21
bhaney
reviewed
Jul 18, 2024
.github/workflows/test.yml
Outdated
Comment on lines
22
to
25
| - name: Run lint | ||
| run: | | ||
| make lint | ||
|
|
There was a problem hiding this comment.
If you already lint in the other github action, you don't need to lint here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the github action for linting on PR
also removed unused functions