-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ RSDK-7903 Include unhealthy remotes in resource list with status #4273
Closed
maximpertsov
wants to merge
41
commits into
viamrobotics:main
from
maximpertsov:RSDK-7903-unhealthy-remotes-replace-names
Closed
⚠️ RSDK-7903 Include unhealthy remotes in resource list with status #4273
maximpertsov
wants to merge
41
commits into
viamrobotics:main
from
maximpertsov:RSDK-7903-unhealthy-remotes-replace-names
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Aug 8, 2024
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-remotes-replace-names
branch
from
August 8, 2024 03:39
aeeba0d
to
36dbd45
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Aug 8, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Aug 9, 2024
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-remotes-replace-names
branch
from
August 9, 2024 21:08
73cae61
to
4153c0c
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Aug 9, 2024
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-remotes-replace-names
branch
from
August 9, 2024 21:17
fb91e32
to
c30937d
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Aug 9, 2024
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-remotes-replace-names
branch
from
August 20, 2024 20:12
c30937d
to
e2243e1
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Aug 20, 2024
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-remotes-replace-names
branch
from
August 20, 2024 22:07
bbc5e4c
to
e2243e1
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Aug 20, 2024
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-remotes-replace-names
branch
from
August 21, 2024 19:36
e2243e1
to
fd0784b
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Aug 21, 2024
the logs we are testing for are output by an internal logger
…ogic Bundled changes from pairing session: * fix remote node lookup nodes correctly * update to MachineStatus return an error and no statuses when a client is disconnected * update tests accordingly
This reverts commit 34bc7f4.
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-remotes-replace-names
branch
from
October 3, 2024 18:45
0ae58aa
to
022194a
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Oct 3, 2024
superseded by #4421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Keep remote resources in the
ResourceNames
andMachineStatus
APIs when their remote gets disconnected. In the latter API, mark such resources with a state indicate that they are disconnected.Prerequisites
To make reviews a bit easier, this PR is going to broken out into smaller chunks:
Details
Robot clients now fetch and cache resource statuses via the
GetMachineStatus
API instead of resource names viaResourceNames
API.Open questions
NodeStateDisconnected
), or is it sufficient to reuse the unhealthy state with a corresponding error (e.g.NodeStateUnhealthy[reason:disconnected]
)?MachineStatus
on the local or remote machine, respectively. Having a specialized state that can only appear for remote resources feels like the less confusing option in this case.Depends on