Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ RSDK-7903 Include unhealthy remotes in resource list with status #4273

Conversation

maximpertsov
Copy link
Contributor

@maximpertsov maximpertsov commented Aug 8, 2024

⚠️ hold off on reviewing for now - the following issue needs to be addressed first


Summary

Keep remote resources in the ResourceNames and MachineStatus APIs when their remote gets disconnected. In the latter API, mark such resources with a state indicate that they are disconnected.

Prerequisites

To make reviews a bit easier, this PR is going to broken out into smaller chunks:

Details

Robot clients now fetch and cache resource statuses via the GetMachineStatus API instead of resource names via ResourceNames API.

Open questions

  • Should we add a new state for disconnected nodes? (e.g. NodeStateDisconnected), or is it sufficient to reuse the unhealthy state with a corresponding error (e.g. NodeStateUnhealthy[reason:disconnected])?
    • FWIW, I slightly prefer a new state given the proposed implementation, since a healthy but disconnected remote resource can appear as "disconnected" or "ready" depending on whether a client calls MachineStatus on the local or remote machine, respectively. Having a specialized state that can only appear for remote resources feels like the less confusing option in this case.
  • Shall we bubble up remote update errors? (see this comment and this comment) - this will make the PR much noisier but might be the correct thing to do.

Depends on

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Aug 8, 2024
@maximpertsov maximpertsov force-pushed the RSDK-7903-unhealthy-remotes-replace-names branch from aeeba0d to 36dbd45 Compare August 8, 2024 03:39
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 8, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 9, 2024
@maximpertsov maximpertsov force-pushed the RSDK-7903-unhealthy-remotes-replace-names branch from 73cae61 to 4153c0c Compare August 9, 2024 21:08
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 9, 2024
@maximpertsov maximpertsov force-pushed the RSDK-7903-unhealthy-remotes-replace-names branch from fb91e32 to c30937d Compare August 9, 2024 21:17
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 9, 2024
@maximpertsov maximpertsov force-pushed the RSDK-7903-unhealthy-remotes-replace-names branch from c30937d to e2243e1 Compare August 20, 2024 20:12
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 20, 2024
@maximpertsov maximpertsov force-pushed the RSDK-7903-unhealthy-remotes-replace-names branch from bbc5e4c to e2243e1 Compare August 20, 2024 22:07
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 20, 2024
@maximpertsov maximpertsov force-pushed the RSDK-7903-unhealthy-remotes-replace-names branch from e2243e1 to fd0784b Compare August 21, 2024 19:36
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 21, 2024
@maximpertsov maximpertsov force-pushed the RSDK-7903-unhealthy-remotes-replace-names branch from 0ae58aa to 022194a Compare October 3, 2024 18:45
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Oct 3, 2024
@maximpertsov
Copy link
Contributor Author

superseded by #4421

@maximpertsov maximpertsov deleted the RSDK-7903-unhealthy-remotes-replace-names branch October 7, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants