-
Notifications
You must be signed in to change notification settings - Fork 126
[RSDK-10991] Create Go helpers for implementing GetImage if you have GetImages and vice versa #5055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
|
This approach will force us to do decodes and encodes. I agree we need this behavior as a fallback but I'm wondering: If the method we call returns an image.Image that happens to be a LazyImage can we save ourselves some decodes and encodes? |
Let me think through this: For For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add test cases for mimetypes with lazy suffix?
RSDK-10991
Create Go helpers for implementing GetImage if you have GetImages and vice versa