RSDK-8813: Add frame_rate to python sdk #740
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckras
changed the title
jckras
commented
Sep 23, 2024
src/viam/version_metadata.py
Outdated
There was a problem hiding this comment.
When trying to compile locally I had to remove the "v" from "v0.1.340" because there was another "v" being added in the makefile - not sure if this will cause a problem with github
jckras
requested review from
njooma and
gloriacai01
and removed request for
gloriacai01
|
Q: I am having trouble getting the tests to pass since the API changes do not seem to be showing up/the new proto files are not being used. How can I fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by the API changes being merged (API PR #553)
frame_rateto the GetProperties() in service.pyframe_ratein the MockCamera for testing and added a check forframe_ratein test_camera.py