Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-6785: Allow different service host from webrtc host #411

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

ethanlookpotts
Copy link
Contributor

@ethanlookpotts ethanlookpotts commented Nov 8, 2024

createRobotClient uses the host for both the service host and the WebRTC host. In the case of a machine running with a local config (not using the cloud config), these values can be different. By providing a way to override the service host, createRobotClient can connect to machines running with a local config.

This is not a breaking change because existing WebRTC configs will not have serviceHost specified.

This was tested by using the Vanilla example with the following config:

    machine = await VIAM.createRobotClient({
      serviceHost: "http://localhost:8080",
      host: "localhost:8080", // or the FQDN specified in config.nework.fqdn
      signalingAddress: '',
    });

@ethanlookpotts ethanlookpotts merged commit c33c1d2 into main Nov 11, 2024
3 checks passed
@ethanlookpotts ethanlookpotts deleted the APP-6785/ethanlookpotts/service-host branch November 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants