Improved Current Progress Bar Time Readability for Screen Readers #8985
+208
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new component inside
SeekBar
to support human understandable time by screen-readers.If seek bar is at 0:20/14:05, then screen reader will announce 'twenty seconds of 14 minutes, 5 seconds.
Specific Changes proposed
progress-time-display.js
insideSeekbar.js
.Intl_PluralRules
api to format numbers according to pluralization rules for different languages.aria-valuetext
. This was being read by the screen reader.For Localisation , time_units would be defined for specific languages:-
"time_units": {
"hour": { "one": "hour", "other": "hours" },
"minute": { "one": "minute", "other": "minutes" },
"second": { "one": "second", "other": "seconds" }
}
Here,
one means :
singular value of that unit
other mean :
plural value of that unit
Requirements Checklist
npm run docs:api
to error