-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(json) support for deck.gl widgets #9314
Open
chrisgervang
wants to merge
4
commits into
master
Choose a base branch
from
chr/widgets-in-json
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2024
Open
Looking forward to a published version of the json module. I am integrating a copy of the playground in deck.gl-community and would love to be able to use widgets there. |
ibgreen
approved these changes
Dec 21, 2024
@@ -5,6 +5,7 @@ | |||
<title>deck.gl Playground</title> | |||
<meta name="viewport" content="width=device-width, initial-scale=1"> | |||
<link href='https://unpkg.com/[email protected]/dist/maplibre-gl.css' rel='stylesheet' /> | |||
<link href="https://unpkg.com/deck.gl@^9.0.0/dist/stylesheet.css" rel='stylesheet' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Nice if widgets could dynamically load this stylesheet, maybe as an option
- Or maybe add affordance to the JSON syntax to allow for stylesheets to be specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9056
Background
Demonstrate support for deck.gl widgets in the
@deck.gl/json
sub-module.Change List