Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(json) support for deck.gl widgets #9314

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chrisgervang
Copy link
Collaborator

For #9056

Background

Demonstrate support for deck.gl widgets in the @deck.gl/json sub-module.

Screenshot 2024-12-20 at 3 33 11 PM

Change List

  • add widget classes to json configuration in playground

@coveralls
Copy link

coveralls commented Dec 20, 2024

Coverage Status

coverage: 91.703%. remained the same
when pulling 2bee7f3 on chr/widgets-in-json
into 06f80f1 on master.

@ibgreen
Copy link
Collaborator

ibgreen commented Dec 21, 2024

Looking forward to a published version of the json module. I am integrating a copy of the playground in deck.gl-community and would love to be able to use widgets there.

@@ -5,6 +5,7 @@
<title>deck.gl Playground</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
<link href='https://unpkg.com/[email protected]/dist/maplibre-gl.css' rel='stylesheet' />
<link href="https://unpkg.com/deck.gl@^9.0.0/dist/stylesheet.css" rel='stylesheet' />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Nice if widgets could dynamically load this stylesheet, maybe as an option
  • Or maybe add affordance to the JSON syntax to allow for stylesheets to be specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants