Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid parsing incorrect date in useSyncInteractiveFilters #2086

Open
bprusinowski opened this issue Feb 5, 2025 · 2 comments
Open

Avoid parsing incorrect date in useSyncInteractiveFilters #2086

bprusinowski opened this issue Feb 5, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@bprusinowski
Copy link
Collaborator

See the #2085 for more context – we fixed a bug with interactive time range brush just before PROD release and should tackle it properly when time allows.

@tboeni
Copy link

tboeni commented Feb 6, 2025

hi @bprusinowski
Thanks for the quick fix and the slider in the edit menu is fixed indeed! However the slider in the diagram itself seems to be working autonomous still, both during edit and publish mode.

Image

@sosiology
Copy link
Contributor

Hi @tboeni

thank you for your comment and the clarification. We tested and assessed the issue you reported, and in our opinion the slider in the chart is behaving as expected when the interactive filter is set and the "most recent year" toggle is active. The intended behaviour is that the chart updates when new data is added and that users can freely move the slider in the chart, not that the time slider interaction is "locked" to the most recent date.

In the side panel, where the chart editor sets the filters, if the option "use most recent" is toggled, the slider only shows one "dot" at the beginning date, as the end date will always be defined by the data and the most recent year available (as seen in the screen recording below).

Screen.Recording.2025-02-06.at.11.02.11.mov

In the chart itself, we include dots at both the beginning and end of the time slider. This allows the user to interact with the data and view different date ranges and "zoom-in" to a specific time period of their choice. When the data is updated with a new year, the chart should adjust automatically to show the latest date on the x axis.

If I've misunderstood your comment or if you feel the current behavior needs enhancement, please let me know. I'm happy to add this topic to the next weekly call's agenda.

cc: @adintegra @bprusinowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants