fix: Most recent filter + interactive time range #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
noahonyejese
approved these changes
Feb 5, 2025
Comment on lines
+125
to
+126
| // FIXME: Should be fixed in useSyncInteractiveFilters where we try to parse | ||
| // the date that can be a string (VISUALIZE_MOST_RECENT_VALUE). |
There was a problem hiding this comment.
Is this something worth opening an issue for? Or how urgent is this? Any specific timeline we want to tackle this? - sorry for all the questions 😅
There was a problem hiding this comment.
Sorry for such late notification @noahonyejese (automatic review request as code owner), I didn't expect a review at such time, but wanted to open a PR so we have it documented (but thank you for the review 🔝). This is a hot-fix just before the PROD release tomorrow in the morning, but I'll open an issue to fix it properly 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes initialization of published charts that use most recent date filter together with interactive filter, so that the full range is displayed, instead of being "stuck" in the start date.
How to test
How to reproduce
Follow the above steps on TEST and see that chart is broken in published mode (only a single year is selected in interactive filter).
cc @sosiology