Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused sparseml.export utilities #950

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Dec 3, 2024

Background

  • While implementing Vision Datasets #943, I discovered a list of model files which conflict with the files that would be saved by image processors

Purpose

  • Remove old utilities which are not used and are misleading w.r.t. how llm-compressor currently works

Changes

  • Remove the following functions and constant definitions
"TaskNames",
"resolve_sequence_length",
"ALL_TASK_NAMES",
"create_fake_dataloader",
"POSSIBLE_TOKENIZER_FILES",
"download_repo_from_huggingface_hub",
"download_model_directory",
  • Rename RECIPE_NAME to RECIPE_FILE_NAME and make use of it in compressed_tensors_utils.py, session_mixin.py, and model_load/helpers
  • Add import for ModelArguments, TrainingArguments when type checking

Testing

grep -r 'RECIPE_NAME\|TaskNames\|resolve_sequence_length\|ALL_TASK_NAMES\|create_fake_dataloader\|POSSIBLE_TOKENIZER_FILES\|download_repo_from_huggingface_hub\|download_model_directory' src/ examples/ tests/
grep -r '"recipe.yaml"' src/

Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs mentioned this pull request Dec 3, 2024
@kylesayrs kylesayrs changed the title Remove sparseml utilities Remove unused sparseml utilities Dec 3, 2024
@kylesayrs kylesayrs changed the title Remove unused sparseml utilities Remove unused sparseml.export utilities Dec 3, 2024
Signed-off-by: Kyle Sayers <[email protected]>
@vllm-project vllm-project deleted a comment from github-actions bot Dec 3, 2024
@kylesayrs kylesayrs self-assigned this Dec 3, 2024
@kylesayrs kylesayrs marked this pull request as draft December 3, 2024 16:36
@kylesayrs kylesayrs marked this pull request as ready for review December 3, 2024 16:56
Signed-off-by: Kyle Sayers <[email protected]>
@dsikka dsikka merged commit 1830382 into main Dec 5, 2024
6 of 7 checks passed
@dsikka dsikka deleted the kylesayrs/remove-sparseml-utilities branch December 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants