Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused sparseml.export utilities #950

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Remove unused sparseml.export utilities #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bf4744a
remove sparseml utilities
kylesayrs Dec 3, 2024
7e516c1
use in model_load
kylesayrs Dec 3, 2024
9e33641
remove use of RECIPE FILE NAME
kylesayrs Dec 3, 2024
58c0fba
rename to RECIPE_FILE_NAME, avoid circular import
kylesayrs Dec 3, 2024
1180b34
remove qa ignore
kylesayrs Dec 3, 2024
78656e1
Merge branch 'main' into kylesayrs/remove-sparseml-utilities
dsikka Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/llmcompressor/pytorch/model_load/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
"save_completed_stages",
]

RECIPE_FILE_NAME = "recipe.yaml"


def log_model_load(
model: Module, model_name_or_path: str, model_type: str, delayed_load: bool
Expand Down Expand Up @@ -106,6 +104,8 @@ def save_model_and_recipe(
:param save_safetensors: whether to save as safetensors or pickle (bin)
:param save_compressed: whether to compress sparse weights on disk
"""
# avoid circular import
from llmcompressor.transformers.utils.helpers import RECIPE_FILE_NAME

model.save_pretrained(
save_path, save_compressed=save_compressed, safe_serialization=save_safetensors
Expand Down
3 changes: 2 additions & 1 deletion src/llmcompressor/transformers/finetune/session_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
from llmcompressor.modifiers.distillation.utils.pytorch.model_wrapper import (
KDModelWrapper,
)
from llmcompressor.pytorch.model_load.helpers import RECIPE_FILE_NAME, get_session_model
from llmcompressor.pytorch.model_load.helpers import get_session_model
from llmcompressor.pytorch.utils import ModuleSparsificationInfo
from llmcompressor.transformers import RECIPE_FILE_NAME
from llmcompressor.transformers.finetune.callbacks import (
DisableHalfPrecisionCallback,
TrainingLoopCallbacks,
Expand Down
3 changes: 2 additions & 1 deletion src/llmcompressor/transformers/sparsification/compressed_tensors_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from llmcompressor.transformers.compression.sparsity_config import (
SparsityConfigMetadata,
)
from llmcompressor.transformers.utils import RECIPE_FILE_NAME
from llmcompressor.utils.fsdp.helpers import (
find_and_move_state_dicts_to_cpu,
unwrap_and_export_model,
Expand Down Expand Up @@ -189,7 +190,7 @@ def skip(*args, **kwargs):
)
compressor.update_config(save_directory)

recipe_path = os.path.join(save_directory, "recipe.yaml")
recipe_path = os.path.join(save_directory, RECIPE_FILE_NAME)
session = active_session()

if (recipe_yaml_str := session.get_serialized_recipe()) is not None:
Expand Down
Loading
Loading