Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] Drop Python 3.8 support #10038

Merged
merged 7 commits into from
Nov 6, 2024
Merged

[CI/Build] Drop Python 3.8 support #10038

merged 7 commits into from
Nov 6, 2024

Conversation

russellb
Copy link
Collaborator

@russellb russellb commented Nov 5, 2024 •
edited
Loading

706e360 [CI/Build] Drop Python 3.8 support
bbdf33a [Core] Make use of str.removeprefix()

commit 706e360
Author: Russell Bryant [email protected]
Date: Tue Nov 5 09:23:59 2024 -0500

[CI/Build] Drop Python 3.8 support

Pytorch 3.5 dropped support for Python 3.8, so it's time we do the
same.

Signed-off-by: Russell Bryant <[email protected]>

commit bbdf33a
Author: Russell Bryant [email protected]
Date: Tue Nov 5 09:29:37 2024 -0500

[Core] Make use of str.removeprefix()

Previously we had a custom implementation of this to support Python
3.8 since this method was added in Python 3.9. Now that we have
dropped 3.8, we can use the built-in method for this.

Signed-off-by: Russell Bryant <[email protected]>

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Nov 5, 2024
@DarkLight1337
Copy link
Member

There is an existing PR #8464 but the author seems too busy to handle this.

@russellb russellb mentioned this pull request Nov 5, 2024
Merged
@russellb
Copy link
Collaborator Author

russellb commented Nov 5, 2024

There is an existing PR #8464 but the author seems too busy to handle this.

gotcha - I didn't see that one. Unless the author picks it back up, I'm happy to take it over.

@DarkLight1337 DarkLight1337 mentioned this pull request Nov 5, 2024
Merged
@russellb
[CI/Build] Drop Python 3.8 support
1e9bbed 
Pytorch 3.5 dropped support for Python 3.8, so it's time we do the
same.

Signed-off-by: Russell Bryant <[email protected]>
@russellb
[Core] Make use of str.removeprefix()
8c99ea0 
Previously we had a custom implementation of this to support Python
3.8 since this method was added in Python 3.9. Now that we have
dropped 3.8, we can use the built-in method for this.

Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb marked this pull request as ready for review November 5, 2024 18:32
@DarkLight1337
Copy link
Member

Quick heads-up that the author has picked up the other PR.

@mergify Mergify
Copy link

mergify bot commented Nov 6, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @russellb please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 6, 2024
@DarkLight1337
Merge branch 'main' into drop-python-3.8
a3e0186 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Remove note
18634b4 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Resolve type error
2442fb5 
Signed-off-by: DarkLight1337 <[email protected]>
@mergify mergify bot removed the needs-rebase label Nov 6, 2024
@DarkLight1337
Format
5628293 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
format
12b270f 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Copy link
Member

I have added some things that were missed in other PR to this PR. See if this looks good to you @russellb

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 6, 2024
@russellb
Copy link
Collaborator Author

russellb commented Nov 6, 2024

I have added some things that were missed in other PR to this PR. See if this looks good to you @russellb

lgtm!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 6, 2024 13:46
@DarkLight1337 DarkLight1337 merged commit 098f94d into vllm-project:main Nov 6, 2024
82 checks passed
@jikunshang jikunshang mentioned this pull request Nov 7, 2024
Merged
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@russellb @DarkLight1337 @JC1DA
[CI/Build] Drop Python 3.8 support (vllm-project#10038)
d691653 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@russellb @DarkLight1337 @sumitd2
[CI/Build] Drop Python 3.8 support (vllm-project#10038)
79ba4b5 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@russellb @DarkLight1337
[CI/Build] Drop Python 3.8 support (vllm-project#10038)
3077c1b 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@russellb @DarkLight1337 @mfournioux
[CI/Build] Drop Python 3.8 support (vllm-project#10038)
c064352 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@russellb @DarkLight1337 @tlrmchlsmth
[CI/Build] Drop Python 3.8 support (vllm-project#10038)
20cad0c 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@russellb @DarkLight1337
[CI/Build] Drop Python 3.8 support (vllm-project#10038)
9c165d6 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russellb @DarkLight1337 @youkaichao