-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Split up pooling tasks #10820
[Misc] Split up pooling tasks #10820
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
b4964ad
to
5d3a629
Compare
Signed-off-by: DarkLight1337 <[email protected]>
3627461
to
39f7d7c
Compare
Signed-off-by: DarkLight1337 <[email protected]>
39f7d7c
to
11fbad1
Compare
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
cc @russellb see if these new doc additions look good to you! |
@Isotr0py would be great if you could review this as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Just a comment about the score
task.
Signed-off-by: DarkLight1337 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Akshat Tripathi <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
As part of #10674, split up the
embedding
task into the following tasks for pooling models:embed
), with default poolerpooling_type=LAST, normalize=True
classify
), with default poolerpooling_type=LAST, softmax=True
scoring
)reward
), with default poolerpooling_type=ALL
peiyi9979/math-shepherd-mistral-7b-prm
conflicting with otherLlamaForCausalLM
pooling models, we will remove the pooler default from the text generation model. Since users already have to overridestep_tag_id
etc. anyway to use that model, this should not be a major breaking change.Backwards compatibility
embedding
remains available as an alias toembed
.--task embedding
is passed but the requested pooling model is not an embedding model, a deprecation warning is emitted.--task embedding
exclusive to embedding models.