[Bugfix] Handle <|tool_call|> token in granite tool parser #11039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak to the granite tool parser to support handle the
<|tool_call|>
token that can be generated, eg.REF: Table 3 on page 14 in https://github.com/ibm-granite/granite-3.0-language-models/blob/main/paper.pdf
Supporting this matters if the request has
skip_special_tokens=False
. Currently, the parser will not parse out the tool call when the output starts with<|tool_call|>
.I have also noticed interesting behavior between the granite model and llama w.r.t handling the tool call special token. With
meta-llama/Llama-3.1-8B-Instruct
, includingskip_special_tokens=True
on the vLLM request does not skip generation of the<|python_tag|>
special token.cc: @maxdebayser