[Bugfix] Fix empty (nullptr) channelwise scales when loading wNa16 using compressed tensors #6798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running row parallel with channelwise scales, the integer divide in:
would result in a 0 sized tensor (with shape
(0, 8192)
, i.e.tensor([], device='cuda:2', size=(0, 8192), dtype=torch.bfloat16)
) leading to a nullptr getting passed into marlin.This is because when its channelwise
group_size
was getting set toinput_size
which is greater thaninput_size_per_partition
in the row parallel case when tp > 1Now for channelwise scales when running row parallel with a tp > 1 we replicate the scales to all gpus.
This issue was present for the model: "nm-testing/Meta-Llama-3.1-70B-Instruct-quantized.w8a16"