[Build] skip renaming files for release wheels pipeline #9671
Conversation
Signed-off-by: simon-mo <[email protected]>
Signed-off-by: simon-mo <[email protected]>
Signed-off-by: simon-mo <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
| version=$(unzip -p "$wheel" '**/METADATA' | grep '^Version: ' | cut -d' ' -f2) | ||
| echo "Version: $version" | ||
|
|
||
| # If the version contains "dev", rename it to v1.0.0.dev for consistency |
There was a problem hiding this comment.
I thought all wheels are named with vllm-1.0.0.dev-cp38-abi3-manylinux1. We don't have the count after version + commit hash in the name anymore. What other names are you seeing?
There was a problem hiding this comment.
If you check the recent build, they are named by version+hash actually, it is just renamed to 1.0.0.dev
|
Do you need to update the installation doc for the nightly wheel name as well? |
|
what's the changing part? |
|
This PR doesn't change the nightly behavior (renaming all wheels to 1.0.0.dev), it skips the nightly upload on main branch commit with the proper version tag so I can upload it to PyPI |
|
Script worked and @ywang96 made a pass https://buildkite.com/vllm/release/builds/1826#_ Merging to unblock release! |
…#9671) Signed-off-by: simon-mo <[email protected]>
…#9671) Signed-off-by: simon-mo <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…#9671) Signed-off-by: simon-mo <[email protected]> Signed-off-by: rickyx <[email protected]>
…#9671) Signed-off-by: simon-mo <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…#9671) Signed-off-by: simon-mo <[email protected]>
Previously all the wheels are named to v1.0.0.dev but this is not correct for published wheels during my release process. This PR
it would be useful to review the shell script