-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] skip renaming files for release wheels pipeline #9671
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2765f70
[Build] skip renaming files for release wheels pipeline
simon-mo d86eeb0
allow previous behavior
simon-mo 1722eef
allow previous behavior
simon-mo 2006485
fix buildkite
simon-mo a707ca3
Merge branch 'main' of github.com:vllm-project/vllm into fix-wheels-v…
simon-mo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -ex | ||
|
||
# Assume wheels are in artifacts/dist/*.whl | ||
wheel_files=(artifacts/dist/*.whl) | ||
|
||
# Check that exactly one wheel is found | ||
if [[ ${#wheel_files[@]} -ne 1 ]]; then | ||
echo "Error: Expected exactly one wheel file in artifacts/dist/, but found ${#wheel_files[@]}" | ||
exit 1 | ||
fi | ||
|
||
# Get the single wheel file | ||
wheel="${wheel_files[0]}" | ||
|
||
# Rename 'linux' to 'manylinux1' in the wheel filename | ||
new_wheel="${wheel/linux/manylinux1}" | ||
mv -- "$wheel" "$new_wheel" | ||
wheel="$new_wheel" | ||
|
||
# Extract the version from the wheel | ||
version=$(unzip -p "$wheel" '**/METADATA' | grep '^Version: ' | cut -d' ' -f2) | ||
echo "Version: $version" | ||
|
||
# If the version contains "dev", rename it to v1.0.0.dev for consistency | ||
if [[ $version == *dev* ]]; then | ||
new_version="1.0.0.dev" | ||
new_wheel="${wheel/$version/$new_version}" | ||
mv -- "$wheel" "$new_wheel" | ||
wheel="$new_wheel" | ||
version="$new_version" | ||
fi | ||
|
||
# Upload the wheel to S3 | ||
aws s3 cp "$wheel" "s3://vllm-wheels/$BUILDKITE_COMMIT/" | ||
aws s3 cp "$wheel" "s3://vllm-wheels/nightly/" | ||
aws s3 cp "$wheel" "s3://vllm-wheels/$version/" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought all wheels are named with
vllm-1.0.0.dev-cp38-abi3-manylinux1
. We don't have the count after version + commit hash in the name anymore. What other names are you seeing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you check the recent build, they are named by version+hash actually, it is just renamed to 1.0.0.dev