Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velero): remove useless nodeAgent.privileged #509

Merged
merged 2 commits into from
Mar 1, 2024
+7 −4
Merged

fix(velero): remove useless nodeAgent.privileged #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97fe2ab
fix(velero): remove useless `nodeAgent.privileged`
cwrau Oct 16, 2023
f440ce2
chore: release 6.0.0 with upgrading release notes
cwrau Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/velero/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 1.13.0
kubeVersion: ">=1.16.0-0"
description: A Helm chart for velero
name: velero
version: 5.4.1
version: 6.0.0
home: https://github.com/vmware-tanzu/velero
icon: https://cdn-images-1.medium.com/max/1600/1*-9mb3AKnKdcL_QD3CMnthQ.png
sources:
Expand Down
7 changes: 6 additions & 1 deletion charts/velero/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,13 @@ If a value needs to be added or changed, you may do so with the `upgrade` comman
```bash
helm upgrade vmware-tanzu/velero <RELEASE NAME> --reuse-values --set configuration.backupStorageLocation[0].provider=<NEW PROVIDER>
```
## Upgrading Chart

## Upgrading
### Upgrading to 6.0.0

This version removes the `nodeAgent.privileged` field, you should use `nodeAgent.containerSecurityContext.privileged` instead
Comment on lines +92 to +94
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should create another doc, such as BREAKING_CHANGES.md to indicate which versions break the changes rather than write it down in the README.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer to have it all in the README so people don't miss it or have to click on another link to get to critical information.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @qiuming-best @ywk253100 @reasonerjt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be more and more breaking changes with time, and I wish we had a BREAKING_CHANGE.md file to declare these centrally. We then link it in README.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally the break change should be documented in release note.

Since there are upgrading sections in README.md, I think putting the information all in README.md makes more sense.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's do it in README.md. We could use BREAKING_CHANGE.md if required in the future.


## Upgrading Velero

### Upgrading to v1.13

Expand Down
1 change: 0 additions & 1 deletion charts/velero/templates/node-agent-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ spec:
lifecycle: {{ toYaml .Values.nodeAgent.lifecycle | nindent 12 }}
{{- end }}
securityContext:
privileged: {{ .Values.nodeAgent.privileged }}
{{- with $containerSecurityContext }}
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
1 change: 0 additions & 1 deletion charts/velero/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,6 @@ deployNodeAgent: false

nodeAgent:
podVolumePath: /var/lib/kubelet/pods
privileged: false
# Pod priority class name to use for the node-agent daemonset. Optional.
priorityClassName: ""
# Resource requests/limits to specify for the node-agent daemonset deployment. Optional.
Expand Down
Loading