fix(velero): remove useless nodeAgent.privileged
#509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrau
force-pushed
the
fix/node-agent-security-context
branch
from
a92b91c to
6ef3d69
Compare
|
@qiuming-best could you help review this? |
cwrau
force-pushed
the
fix/node-agent-security-context
branch
from
6ef3d69 to
a18f773
Compare
jenting
requested changes
Oct 16, 2023
|
Could you help resolve the conflicting file? Thanks. |
@cwrau do you have time to proceed this issue? |
Oh, I missed the notification, I'll get on it 👍 |
cwrau
force-pushed
the
fix/node-agent-security-context
branch
3 times, most recently
from
a0c01de to
6e496fb
Compare
cwrau
force-pushed
the
fix/node-agent-security-context
branch
from
6e496fb to
52e023d
Compare
this clashes with the field `nodeAgent.containerSecurityContext.privileged` Signed-off-by: Chris Werner Rau <[email protected]>
Signed-off-by: Chris Werner Rau <[email protected]>
cwrau
force-pushed
the
fix/node-agent-security-context
branch
from
52e023d to
f440ce2
Compare
jenting
reviewed
Feb 28, 2024
Comment on lines
+92
to
+94
| ### Upgrading to 6.0.0 | ||
|
|
||
| This version removes the `nodeAgent.privileged` field, you should use `nodeAgent.containerSecurityContext.privileged` instead |
There was a problem hiding this comment.
Do you think we should create another doc, such as BREAKING_CHANGES.md to indicate which versions break the changes rather than write it down in the README.md?
There was a problem hiding this comment.
I personally prefer to have it all in the README so people don't miss it or have to click on another link to get to critical information.
There was a problem hiding this comment.
What do you think @qiuming-best @ywk253100 @reasonerjt
There was a problem hiding this comment.
There will be more and more breaking changes with time, and I wish we had a BREAKING_CHANGE.md file to declare these centrally. We then link it in README.md
There was a problem hiding this comment.
Normally the break change should be documented in release note.
Since there are upgrading sections in README.md, I think putting the information all in README.md makes more sense.
There was a problem hiding this comment.
Okay, let's do it in README.md. We could use BREAKING_CHANGE.md if required in the future.
jenting
approved these changes
Feb 29, 2024
qiuming-best
approved these changes
Mar 1, 2024
renovate bot
referenced
this pull request
in teutonet/teutonet-helm-charts
Mar 25, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [velero](https://togithub.com/vmware-tanzu/velero) ([source](https://togithub.com/vmware-tanzu/helm-charts)) | major | `5.4.1` -> `6.0.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>vmware-tanzu/helm-charts (velero)</summary> ### [`v6.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.0.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-5.4.1...velero-6.0.0) A Helm chart for velero #### What's Changed - fix(velero): remove useless `nodeAgent.privileged` by [@​cwrau](https://togithub.com/cwrau) in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) #### New Contributors - [@​cwrau](https://togithub.com/cwrau) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) **Full Changelog**: vmware-tanzu/helm-charts@velero-5.4.1...velero-6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Mar 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | docker.io/bitnami/kubectl | minor | `1.28.6` -> `1.29.3` | | [registry1.dso.mil/ironbank/opensource/velero/velero](https://velero.io) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero)) | patch | `v1.13.0` -> `v1.13.1` | | [registry1.dso.mil/ironbank/opensource/velero/velero-plugin-for-aws](https://togithub.com/vmware-tanzu/velero-plugin-for-aws) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero-plugin-for-aws)) | patch | `v1.9.0` -> `v1.9.1` | | [velero](https://togithub.com/vmware-tanzu/velero) ([source](https://togithub.com/vmware-tanzu/helm-charts)) | major | `5.4.1` -> `6.0.0` | | velero/velero | patch | `v1.13.0` -> `v1.13.1` | | velero/velero-plugin-for-aws | patch | `v1.9.0` -> `v1.9.1` | --- ### Release Notes <details> <summary>vmware-tanzu/helm-charts (velero)</summary> ### [`v6.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.0.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-5.4.1...velero-6.0.0) A Helm chart for velero #### What's Changed - fix(velero): remove useless `nodeAgent.privileged` by [@​cwrau](https://togithub.com/cwrau) in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) #### New Contributors - [@​cwrau](https://togithub.com/cwrau) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) **Full Changelog**: vmware-tanzu/helm-charts@velero-5.4.1...velero-6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
robmcelvenny
referenced
this pull request
in owen-grady/uds-core-slim-dev
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | docker.io/bitnami/kubectl | minor | `1.28.6` -> `1.29.3` | | [registry1.dso.mil/ironbank/opensource/velero/velero](https://velero.io) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero)) | patch | `v1.13.0` -> `v1.13.1` | | [registry1.dso.mil/ironbank/opensource/velero/velero-plugin-for-aws](https://togithub.com/vmware-tanzu/velero-plugin-for-aws) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero-plugin-for-aws)) | patch | `v1.9.0` -> `v1.9.1` | | [velero](https://togithub.com/vmware-tanzu/velero) ([source](https://togithub.com/vmware-tanzu/helm-charts)) | major | `5.4.1` -> `6.0.0` | | velero/velero | patch | `v1.13.0` -> `v1.13.1` | | velero/velero-plugin-for-aws | patch | `v1.9.0` -> `v1.9.1` | --- ### Release Notes <details> <summary>vmware-tanzu/helm-charts (velero)</summary> ### [`v6.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.0.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-5.4.1...velero-6.0.0) A Helm chart for velero #### What's Changed - fix(velero): remove useless `nodeAgent.privileged` by [@​cwrau](https://togithub.com/cwrau) in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) #### New Contributors - [@​cwrau](https://togithub.com/cwrau) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) **Full Changelog**: vmware-tanzu/helm-charts@velero-5.4.1...velero-6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rjferguson21
referenced
this pull request
in defenseunicorns/uds-core
Jul 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | docker.io/bitnami/kubectl | minor | `1.28.6` -> `1.29.3` | | [registry1.dso.mil/ironbank/opensource/velero/velero](https://velero.io) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero)) | patch | `v1.13.0` -> `v1.13.1` | | [registry1.dso.mil/ironbank/opensource/velero/velero-plugin-for-aws](https://togithub.com/vmware-tanzu/velero-plugin-for-aws) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero-plugin-for-aws)) | patch | `v1.9.0` -> `v1.9.1` | | [velero](https://togithub.com/vmware-tanzu/velero) ([source](https://togithub.com/vmware-tanzu/helm-charts)) | major | `5.4.1` -> `6.0.0` | | velero/velero | patch | `v1.13.0` -> `v1.13.1` | | velero/velero-plugin-for-aws | patch | `v1.9.0` -> `v1.9.1` | --- ### Release Notes <details> <summary>vmware-tanzu/helm-charts (velero)</summary> ### [`v6.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.0.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-5.4.1...velero-6.0.0) A Helm chart for velero #### What's Changed - fix(velero): remove useless `nodeAgent.privileged` by [@​cwrau](https://togithub.com/cwrau) in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) #### New Contributors - [@​cwrau](https://togithub.com/cwrau) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/509](https://togithub.com/vmware-tanzu/helm-charts/pull/509) **Full Changelog**: vmware-tanzu/helm-charts@velero-5.4.1...velero-6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field clashes with the field
nodeAgent.containerSecurityContext.privilegedwhich one sets by muscle memory or, in my case, via a yaml anchor to deduplicate this security effort.Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero])