musl: add 0 large file patch

[dkwo]

• musl: add patch for 0 largefile
• musl: revbump

This would allow e.g. building firefox so that it is usable with musl 1.2.2

General

• This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

• I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
• I generally don't use the affected packages but briefly tested this PR

Builds fine on x86_64-musl.

[dkwo]

@ericonr If you find it ok, perhaps this could be merged before the ff update.

[ericonr]

It should be a single commit and the message should be musl: backport O_LARGE fix with an explanation in the body: "musl 1.2.2 started defining O_LARGEFILE to an actual value for x86_64, which breaks the firefox seccomp filter when built with older musl headers. backporting this change and building firefox with it allows one to use a local more up to date musl version with firefox from repos"

[ericonr]

Hmm, we'd have to check if this breaks chromium or the other mozilla packages as well...

[dkwo]

Hmm, we'd have to check if this breaks chromium or the other mozilla packages as well...

Do you mean building or using them?
(As far as using, they seem to work fine with the musl patch.)

[ericonr]

Yeah, using. Because the thing is, by backporting this musl change, we are introducing the issue with musl 1.2.2 to our musl package. So anything that needed to be rebuilt because of musl 1.2.2 in other distros also needs to rebuilt if we merge this in.

[dkwo]

I briefly checked chromium and thunderbird, and they seem to work fine. (Obviously, firefox is broken instead.) Can you think of something else to check?

[ericonr]

Firefox-esr and Thunderbird, at least.

In the opposite direction, I made: https://github.com/ericonr/void-packages/tree/musl-1.2.0

[dkwo]

Your idea is probably smarter.
Thunderbird does not need a revbump thouhg.

[dkwo]

I'm a bit confused: if I build your solution, I still get crash in firefox sandbox with syscal 16, as mentioned in #29632
What am I doing wrong?

[ericonr]

Are you using firefox from repos or from when you built with this patch? There's a chance it's broken when built with the patch but running without it.

[dkwo]

I'm using firefox from the repos.

[dkwo]

Edit: sorry, my bad, I had to delete previous musl build, now it works as expected.

[dkwo]

I think your solution is better, so let's close this.
Thank you.

[ericonr]

You can build with -f to overwrite the existing package build ;)

[dkwo]

Good to know, thanks!