[WIP] Move to BearSSL #324
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
force-pushed
the
bearssl
branch
2 times, most recently
from
80cf547 to
7147897
Compare
There is no need to use raw file descriptors.
BearSSL currently doesn't support decoding the pubkey in the format we are using. Since there are plans for changing the signing algorithm, this shouldn't be an issue for the transition, once the new design is finalized. For now, we are using LibreSSL to decode the PEM string in pubkey into a public key.
No need to check if passing NULL to free().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very WIP, just wanted to leave it open.
I'm also accepting help for solving
lib/verifysig, because reading the pubkey isn't going super well, and I have resorted, for now, to letting LibreSSL do it for me.