-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using jupyterlite-xeus instead of xeus-python #107
Switch to using jupyterlite-xeus instead of xeus-python #107
Conversation
Check-release deciding again to use system yarn for some reason :S |
you may need to activate the conda environment with |
Thanks! I was sure I did that already in the last PR. |
@trungleduc it does not work Actually I looked into doing it at some point but in the end I mimicked what we do in jupytercad, but it does not seem to work here?? |
d558d0c
to
cca9487
Compare
Check-release now works nicely. I'll merge and we can iterate. Next steps:
|
|
||
- name: Check Release | ||
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2 | ||
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like jupyter-server/jupyter_releaser#549 was released as part of https://github.com/jupyter-server/jupyter_releaser/releases/tag/v1.6.0, so we can stick to v2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Thank you I'll make the change in the coming PR
According to the discussion in #104 (comment), it looks like this is likely to be implemented in the xeus addon in https://github.com/jupyterlite/xeus directly? |
No description provided.