Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using jupyterlite-xeus instead of xeus-python #107

Merged
merged 10 commits into from
Jan 24, 2024

Conversation

martinRenou
Copy link
Member

No description provided.

Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@martinRenou martinRenou added the enhancement New feature or request label Jan 23, 2024
@martinRenou
Copy link
Member Author

martinRenou commented Jan 23, 2024

Check-release deciding again to use system yarn for some reason :S

@trungleduc
Copy link
Member

you may need to activate the conda environment with init-shell: bash in the mamba-org/setup-micromamba@v1 action and activate the bash shell in the steps with shell: bash -l {0}

@martinRenou
Copy link
Member Author

Thanks! I was sure I did that already in the last PR.

@martinRenou
Copy link
Member Author

@trungleduc it does not work

Actually I looked into doing it at some point but in the end I mimicked what we do in jupytercad, but it does not seem to work here??

@martinRenou
Copy link
Member Author

Check-release now works nicely. I'll merge and we can iterate.

Next steps:

  • add some documentation
  • use the mounts feature for jupytelite-xeus seamlessly

@martinRenou martinRenou merged commit f825638 into voila-dashboards:main Jan 24, 2024
5 checks passed
@martinRenou martinRenou deleted the jupyterlite-xeus branch January 24, 2024 09:14

- name: Check Release
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@main
Copy link
Member

@jtpio jtpio Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Thank you I'll make the change in the coming PR

@jtpio
Copy link
Member

jtpio commented Jan 24, 2024

use the mounts feature for jupytelite-xeus seamlessly

According to the discussion in #104 (comment), it looks like this is likely to be implemented in the xeus addon in https://github.com/jupyterlite/xeus directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants