Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using jupyterlite-xeus instead of xeus-python #107

Merged
merged 10 commits into from
Jan 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
@@ -2,14 +2,9 @@ name: Check Release

on:
push:
branches:
- main
branches: ['main']
pull_request:
branches:
- main

permissions:
contents: write
branches: ['*']

jobs:
check_release:
@@ -21,16 +16,19 @@ jobs:
- name: Install Conda environment with Micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: voici
environment-name: voici-dev
create-args: >-
python=3.9
yarn=3
pip
jupyter-releaser

- name: Check Release
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@main
Copy link
Member

@jtpio jtpio Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Thank you I'll make the change in the coming PR

with:
token: ${{ secrets.GITHUB_TOKEN }}
version_spec: next
shell: bash -l {0}

- name: Upload Distributions
uses: actions/upload-artifact@v3
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ jobs:

- name: Install voici
run: |
python -m pip install jupyterlite-xeus-python
python -m pip install jupyterlite-xeus
python -m pip install python/voici-core
python -m pip install python/voici

2 changes: 1 addition & 1 deletion docs/environment.yml
Original file line number Diff line number Diff line change
@@ -10,6 +10,6 @@ dependencies:
- yarn=3
- pip:
- sphinxcontrib-video
- jupyterlite-xeus-python
- jupyterlite-xeus
- ../python/voici-core
- ../python/voici
Loading