voxpupuli-rubocop: Require 2.x #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1836 +/- ##
=======================================
Coverage 74.52% 74.52%
=======================================
Files 81 81
Lines 4506 4506
=======================================
Hits 3358 3358
Misses 1148 1148 ☔ View full report in Codecov by Sentry. |
evgeni
reviewed
Nov 23, 2023
| @@ -22,7 +22,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'fakefs', '~> 2.4' | |||
| s.add_development_dependency 'rake', '~> 13.0' | |||
| s.add_development_dependency 'rspec', '~> 3.0' | |||
| s.add_development_dependency 'voxpupuli-rubocop', '~> 1.1' | |||
| s.add_development_dependency 'voxpupuli-rubocop', '~> 2.0.0' | |||
There was a problem hiding this comment.
That means 2.1.0 won't be allowed. Is that intentional?
There was a problem hiding this comment.
Yes. We don't want to pull them in automatically because that could introduce new cops that fail. Instead we will get a PR from dependabot that bumps the version. In that PR we see if it passes or not. And dependabot adds a specific label to it and I review all PRs in our org from time to time with that label.
evgeni
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.