Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voxpupuli-rubocop: Require 2.x #1836

Merged
merged 1 commit into from
Nov 23, 2023
Merged

voxpupuli-rubocop: Require 2.x #1836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beaker.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'fakefs', '~> 2.4'
s.add_development_dependency 'rake', '~> 13.0'
s.add_development_dependency 'rspec', '~> 3.0'
s.add_development_dependency 'voxpupuli-rubocop', '~> 1.1'
s.add_development_dependency 'voxpupuli-rubocop', '~> 2.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means 2.1.0 won't be allowed. Is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We don't want to pull them in automatically because that could introduce new cops that fail. Instead we will get a PR from dependabot that bumps the version. In that PR we see if it passes or not. And dependabot adds a specific label to it and I review all PRs in our org from time to time with that label.


# Run time dependencies
s.add_runtime_dependency 'minitar', '~> 0.6'
Expand Down