Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voxpupuli-rubocop: Require 2.x #1836

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

bastelfreak
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c70832d) 74.52% compared to head (0281359) 74.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files          81       81           
  Lines        4506     4506           
=======================================
  Hits         3358     3358           
  Misses       1148     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'fakefs', '~> 2.4'
s.add_development_dependency 'rake', '~> 13.0'
s.add_development_dependency 'rspec', '~> 3.0'
s.add_development_dependency 'voxpupuli-rubocop', '~> 1.1'
s.add_development_dependency 'voxpupuli-rubocop', '~> 2.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means 2.1.0 won't be allowed. Is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We don't want to pull them in automatically because that could introduce new cops that fail. Instead we will get a PR from dependabot that bumps the version. In that PR we see if it passes or not. And dependabot adds a specific label to it and I review all PRs in our org from time to time with that label.

@bastelfreak bastelfreak merged commit 456ac0a into voxpupuli:master Nov 23, 2023
8 checks passed
@bastelfreak bastelfreak deleted the vr branch November 23, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants