password encryption: switch from des3->aes-256-cbc #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
This updates the algorithm for password encryption in certificates from the outdated des3 to aes-256-cbc.
Merged
ekohl
reviewed
Jul 18, 2024
| @@ -42,7 +42,7 @@ | |||
| it 'creates with given password' do | |||
| resource[:password] = '2x$5{' | |||
| allow(OpenSSL::PKey::RSA).to receive(:new).with(2048).and_return(key) | |||
| allow(OpenSSL::Cipher).to receive(:new).with('des3') | |||
| allow(OpenSSL::Cipher).to receive(:new).with('aes-256-cbc') | |||
There was a problem hiding this comment.
Should we change this to expect? Right now I think the test would also pass if OpenSSL::Cipher.new wasn't called at all.
There was a problem hiding this comment.
Updated it. But I'm an rspec noob. Let me know if this is what you had in mind.
ekohl
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the algorithm for password encryption in certificates from the outdated des3 to aes-256-cbc.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues