Merge pull request #257 from vshn/fix/obj_api_vers_check

Remove v1alpha1 for objects from webhook definition
vshn · Oct 31, 2024 · 62422a9 · 62422a9
2 parents 12d2103 + c58e5a1
commit 62422a9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 20 deletions.
diff --git a/config/controller/webhooks.yaml b/config/controller/webhooks.yaml
@@ -99,25 +99,6 @@ webhooks:
     resources:
     - objects
   sideEffects: None
-- admissionReviewVersions:
-  - v1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-kubernetes-crossplane-io-v1alpha1-object
-  failurePolicy: Fail
-  name: objectsv1alpha1.vshn.appcat.vshn.io
-  rules:
-  - apiGroups:
-    - kubernetes.crossplane.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - DELETE
-    resources:
-    - objects
-  sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:

diff --git a/pkg/controller/webhooks/object.go b/pkg/controller/webhooks/object.go
@@ -6,7 +6,6 @@ import (
 	ctrl "sigs.k8s.io/controller-runtime"
 )
 
-//+kubebuilder:webhook:verbs=delete,path=/validate-kubernetes-crossplane-io-v1alpha1-object,mutating=false,failurePolicy=fail,groups="kubernetes.crossplane.io",resources=objects,versions=v1alpha1,name=objectsv1alpha1.vshn.appcat.vshn.io,sideEffects=None,admissionReviewVersions=v1
 //+kubebuilder:webhook:verbs=delete,path=/validate-kubernetes-crossplane-io-v1alpha2-object,mutating=false,failurePolicy=fail,groups="kubernetes.crossplane.io",resources=objects,versions=v1alpha2,name=objects.vshn.appcat.vshn.io,sideEffects=None,admissionReviewVersions=v1
 
 //+kubebuilder:rbac:groups=syn.tools,resources=compositeredisinstances,verbs=get;list;watch;patch;update