-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tooltip component #2644
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
d454cc5
to
1269495
Compare
|
||
position: absolute; | ||
z-index: var(--fs-tooltip-z-index); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not have a cursor point
here?
See an example: https://www.chakra-ui.com/docs/components/tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think you don't need to add it. Maybe the cursor behaviour depends on the Children element.
What's the purpose of this pull request?
This pull request adds the Tooltip atom component. This component will be used in the ReviewCard for displaying reviews of a product in the new Reviews and Ratings section.
How does it work?
This PR introduces a new molecule component,
Tooltip
, which allows customization of its behavior and appearance. The component includes default values for some of its props:placement
is"top"
,dismissable
isfalse
, andmaxWidth
is300
.When
dismissable
is enabled, the tooltip uses anIconButton
for the dismiss action.How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2070
Figma