Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltip component #2644

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

artursantiago
Copy link
Collaborator

@artursantiago artursantiago commented Jan 28, 2025

What's the purpose of this pull request?

This pull request adds the Tooltip atom component. This component will be used in the ReviewCard for displaying reviews of a product in the new Reviews and Ratings section.

How does it work?

This PR introduces a new molecule component, Tooltip, which allows customization of its behavior and appearance. The component includes default values for some of its props: placement is "top", dismissable is false, and maxWidth is 300.

When dismissable is enabled, the tooltip uses an IconButton for the dismiss action.

How to test it?

Starters Deploy Preview

Preview

References

JIRA TASK: SFS-2070

Figma

image

@artursantiago artursantiago added the enhancement New feature or request label Jan 28, 2025
@artursantiago artursantiago self-assigned this Jan 28, 2025
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview Jan 28, 2025 5:45pm

Copy link

codesandbox-ci bot commented Jan 28, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@artursantiago artursantiago marked this pull request as ready for review January 30, 2025 17:43
@artursantiago artursantiago requested a review from a team as a code owner January 30, 2025 17:43
@artursantiago artursantiago requested review from eduardoformiga and lucasfp13 and removed request for a team January 30, 2025 17:43
@artursantiago artursantiago force-pushed the feat/add-tooltip-component branch from d454cc5 to 1269495 Compare February 4, 2025 18:36

position: absolute;
z-index: var(--fs-tooltip-z-index);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not have a cursor point here?
See an example: https://www.chakra-ui.com/docs/components/tooltip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think you don't need to add it. Maybe the cursor behaviour depends on the Children element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants