Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add suggestions to no-unused-vars tests #2650

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Dec 16, 2024

eslint/eslint#18352

The upstream landed the above PR to add suggestion fixers, which caused some test cases to fail.

This PR fix these tests.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost exactly like what I have done in #2651, so it would be weird if I'd not approve this 😉 😄

Thanks for adding this!

@FloEdelmann FloEdelmann merged commit 9453949 into vuejs:master Dec 16, 2024
18 checks passed
@waynzh
Copy link
Member Author

waynzh commented Dec 16, 2024

😄

@waynzh waynzh deleted the add-suggestions branch December 16, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants