Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestions to no-unused-vars tests on ESLint v9.17.0+ #2651

Closed
wants to merge 1 commit into from

Conversation

FloEdelmann
Copy link
Member

The ESLint core rule no-unused-vars added suggestions in v9.17.0. This caused some failed tests on our side: https://github.com/vuejs/eslint-plugin-vue/actions/runs/12348943800/job/34458740723

This PR adds the suggestions in the tests if ESLint version is >= v9.17.0.

@FloEdelmann FloEdelmann added the meta Code style improvements, build process improvements, refactorings label Dec 16, 2024
@FloEdelmann
Copy link
Member Author

Ooops, @waynzh was faster than me in #2650 😅
Closing this as a duplicate then.

@FloEdelmann FloEdelmann deleted the no-unused-vars-suggestions branch December 16, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate meta Code style improvements, build process improvements, refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant