fix a path building issue #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
requested changes
Mar 21, 2024
src/agent/driver-test-runner.js
Outdated
| const base = `${this.baseUrl.protocol}://${this.baseUrl.hostname}:${this.baseUrl.port}/${this.baseUrl.pathname}`; | ||
| // protocol ends with a ':' and pathname starts with a '/' | ||
| const base = `${this.baseUrl.protocol}//${this.baseUrl.hostname}:${this.baseUrl.port}${this.baseUrl.pathname}`; | ||
| const urlPart = `${this.baseUrl.pathname ? `${this.baseUrl.pathname}/` : ''}${pathname}`; |
There was a problem hiding this comment.
This variable is unused. (It's concerning that this wasn't flagged in CI...)
There was a problem hiding this comment.
agree on concern - pushed fix (for this issue, not the concern)
jugglinmike
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might've snuck in with the latest TSC stuff but I ran into an error of "Invalid URL" when trying to run latest main on my machine.
noticed there was a doubled
:and/in the base url herehttp:://127.0.0.1:1234//urlis what it looked like