Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a path building issue #45

Merged
merged 2 commits into from
Mar 21, 2024
+4 −2
Merged

fix a path building issue #45

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97b1fd9
fix a path building issue
gnarf Mar 21, 2024
bcd5094
fix unused variable
gnarf Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
fix unused variable
@gnarf
gnarf committed Mar 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit bcd5094fb51c63b473c70144de6fb637829cbf82
4 changes: 2 additions & 2 deletions src/agent/driver-test-runner.js
View file
Original file line number Diff line number Diff line change
@@ -279,8 +279,8 @@ export class DriverTestRunner {
_appendBaseUrl(pathname) {
// protocol ends with a ':' and pathname starts with a '/'
const base = `${this.baseUrl.protocol}//${this.baseUrl.hostname}:${this.baseUrl.port}${this.baseUrl.pathname}`;
const urlPart = `${this.baseUrl.pathname ? `${this.baseUrl.pathname}/` : ''}${pathname}`;
return new URL(`${this.baseUrl.pathname ? `${this.baseUrl.pathname}/` : ''}${pathname}`, base);
const newPath = `${this.baseUrl.pathname ? `${this.baseUrl.pathname}/` : ''}${pathname}`;
return new URL(newPath, base);
}
}