Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Service's structure of DIDCommMessaging #548

Merged

Conversation

FabioPinheiro
Copy link
Contributor

@FabioPinheiro FabioPinheiro commented Mar 4, 2024

Minor fix on the DID document Service's structure for the type DIDCommMessaging.

The serviceEndpoint MUST be a json object with the fields uri, accept and routingKeys


Preview | Diff

@msporny
Copy link
Member

msporny commented Apr 1, 2024

Copy link
Collaborator

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should clarify in the spec if it is mandatory to encode serviceEndpoint as an array, or if it's possible to define it as an object in case of a single entry.

"did:example:somemediator#somekey"
]
...
"serviceEndpoint": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current DIDComm V2 spec says that serviceEndpoint MUST contain an ordered list of objects.. This makes me think that, if you have a single endpoint, you'll need to define it as a list containing this single object.

However, in this example (and also Peer DID method specification), serviceEndpoint is encoded as an object.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I was looking at DIDComm v2.0 but the latest stable version is v2.1, which allows for the encoding of an object. That explains why all other specs were 'wrong' :D

@@ -1642,17 +1642,12 @@ <h4>DIDCommMessaging</h4>
"https://www.w3.org/ns/did/v1",
"https://didcomm.org/messaging/contexts/v2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly related to this PR, but I think it's worth noting that this URL returns 404. It seems this issue was addressed some time ago (see decentralized-identity/didcomm.org#9) but somehow the link is broken again.

BTW the context file located at https://github.com/decentralized-identity/didcomm.org/blob/main/docs/messaging/contexts/v2/index.json seems to be using the old format.

@msporny msporny force-pushed the fix_Service_DIDCommMessaging_structure branch from 37e3cc3 to ec905eb Compare July 20, 2024 21:10
@msporny msporny merged commit 7e883fe into w3c:main Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants