Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Service's structure of DIDCommMessaging #548

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Fix the Service's structure of DIDCommMessaging #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,17 +1697,12 @@ <h4>DIDCommMessaging</h4>
"https://www.w3.org/ns/did/v1",
"https://didcomm.org/messaging/contexts/v2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly related to this PR, but I think it's worth noting that this URL returns 404. It seems this issue was addressed some time ago (see decentralized-identity/didcomm.org#9) but somehow the link is broken again.

BTW the context file located at https://github.com/decentralized-identity/didcomm.org/blob/main/docs/messaging/contexts/v2/index.json seems to be using the old format.

],
...
"type":"DIDCommMessaging",
"serviceEndpoint":"http://example.com/path",
"accept":[
"didcomm/v2",
"didcomm/aip2;env=rfc587"
],
"routingKeys":[
"did:example:somemediator#somekey"
]
...
"serviceEndpoint": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current DIDComm V2 spec says that serviceEndpoint MUST contain an ordered list of objects.. This makes me think that, if you have a single endpoint, you'll need to define it as a list containing this single object.

However, in this example (and also Peer DID method specification), serviceEndpoint is encoded as an object.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I was looking at DIDComm v2.0 but the latest stable version is v2.1, which allows for the encoding of an object. That explains why all other specs were 'wrong' :D

"uri": "http://example.com/path",
"accept":[ "didcomm/v2", "didcomm/aip2;env=rfc587" ],
"routingKeys":[ "did:example:somemediator#somekey" ]
}
}
</pre>

Expand Down
Loading