Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Browser Permissions for WebDriver BiDi #425

Closed
wants to merge 28 commits into from
Closed

Introduce Browser Permissions for WebDriver BiDi #425

wants to merge 28 commits into from

Conversation

thiagowfx
Copy link
Member

@thiagowfx thiagowfx commented Nov 6, 2023

Based-on: w3c/webdriver-bidi#590
Bug: #424
Bug: w3c/webdriver-bidi#587

Upstream auto-linking blockers:

Other considerations:

This is out of scope of this initial PR. We intend to only achieve feature parity with WebDriver classic.


The following tasks have been completed:

Implementation commitment:


Preview | Diff

thiagowfx pushed a commit to w3c/webdriver-bidi that referenced this pull request Nov 6, 2023
So that they can be referenced from other specs.

Bug: #506
Bug: #587
Bug: w3c/permissions#425
@thiagowfx
Copy link
Member Author

cc @OrKoN @mathiasbynens @jgraham @whimboo (I don't have permissions to change the "assignee" field directly)

@thiagowfx thiagowfx marked this pull request as ready for review November 7, 2023 10:14
index.html Outdated Show resolved Hide resolved
thiagowfx pushed a commit to w3c/webdriver-bidi that referenced this pull request Nov 7, 2023
So that they can be referenced from other specs.

Bug: #506
Bug: #587
Bug: w3c/permissions#425
@thiagowfx
Copy link
Member Author

cc @miketaylr could you PTAL?

index.html Outdated Show resolved Hide resolved
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that if you were to place WebDriver-Bidi after WebDriver, this would be a bit easier to review.

Also, can you fix the build errors?

index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
@thiagowfx thiagowfx marked this pull request as draft November 9, 2023 15:35
@thiagowfx
Copy link
Member Author

thiagowfx commented Nov 9, 2023

Converting this back to draft until I apply all requested changes (from both here and https://www.w3.org/2023/11/08-webdriver-minutes.html#t04).

index.html Outdated Show resolved Hide resolved
@thiagowfx
Copy link
Member Author

Ongoing: exporting terms from the webdriver classic spec:

index.html Outdated Show resolved Hide resolved
@thiagowfx thiagowfx marked this pull request as ready for review November 16, 2023 12:25
index.html Outdated Show resolved Hide resolved
@thiagowfx
Copy link
Member Author

@jgraham @whimboo Does Mozilla / Firefox / Gecko intend to support the browser permissions API for BiDi?

If yes, then could you please file a bug and edit the first comment to include it?
If not, then I will edit it myself to add a note that there's no implementation intent.

Extension modules are optional anyway.

@thiagowfx
Copy link
Member Author

thiagowfx commented Nov 22, 2023

@gsnedders @patrickangle Does Apple / WebKit intend to support the browser permissions API for BiDi?

If yes, then could you please file a bug and edit the first comment to include it?
If not, then I will edit it myself to add a note that there's no implementation intent.

Extension modules are optional anyway.

@thiagowfx
Copy link
Member Author

I believe all suggestions were addressed. PTAL

@miketaylr
Copy link
Member

This branch has conflicts that must be resolved

https://www.youtube.com/watch?v=RlJM8-7IMBM

(let me try to clean this up before reviewing)

@thiagowfx
Copy link
Member Author

If the rebase ends up being straightforward, feel free to merge it (or I can do it).

If there are any follow-ups, Alex (orkon) will take over from here. Thanks!

@OrKoN
Copy link
Contributor

OrKoN commented Nov 27, 2023

I have opened a PR with the rebase here #431 since I have no permissions to @thiagowfx fork. Let's close this PR in favor of the new PR.

@miketaylr
Copy link
Member

I have opened a PR with the rebase here #431 since I have no permissions to @thiagowfx fork. Let's close this PR in favor of the new PR.

Sounds good.

@miketaylr miketaylr closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants