Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Browser Permissions for WebDriver BiDi #425
Introduce Browser Permissions for WebDriver BiDi #425
Changes from 10 commits
37f9781
437ba0b
d7310e3
22c53fa
49bec97
7c9e37b
5ffe92c
b9fed1f
acf0653
5e37655
163fc86
98dd229
12f450b
afd657c
0242b84
67e7e63
b97d2fb
4a5f3fd
edce1e0
c6eaf4c
5a18fe1
175f816
a8647fe
fcd4cb2
edd94bc
2f2dfb2
4057e4a
0183692
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a little confusing... I was expecting:
Let |task| be ... steps...
[=Queue a task=] |task| ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of pre-existing prose: https://www.w3.org/TR/permissions/#set-permission-command
Should I make the proposed change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would they do that though? It can only be set to "granted", "denied", or "prompt" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is part of pre-existing prose. Updated anyway.