Require an explicit origin for WebDriver BiDi automation #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WebDriver classic permissions apply to all enviroments that match the origin of the current environment. In WebDriver BiDi using the current view as an input for commands is not encouraged, therefore, this PR extends the WebDriver BiDi command with an explicit origin parameter.
miketaylr
requested changes
Jan 12, 2024
Co-authored-by: Mike Taylor <[email protected]>
miketaylr
approved these changes
Jan 14, 2024
|
wat - will look at this later today.
|
|
Re-ran it.... all green now. (respec.org was temporarily down... could have been that) |
|
Thanks Marcos! |
github-actions bot
added a commit
that referenced
this pull request
Jan 16, 2024
SHA: 8972985 Reason: push, by miketaylr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WebDriver classic permissions apply to all enviroments that match the origin of the current environment. In WebDriver BiDi using the current view as an input for commands is not encouraged, therefore, this PR extends the WebDriver BiDi command with an explicit origin parameter.
Closes #424
The following tasks have been completed:
Implementation commitment:
Preview | Diff