Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require an explicit origin for WebDriver BiDi automation #436

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Require an explicit origin for WebDriver BiDi automation #436

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe5e0cb
Require an explicit origin for WebDriver BiDi automation
OrKoN Jan 12, 2024
3c097dd
Update index.html
OrKoN Jan 13, 2024
0f7eb99
Change to optional origin
OrKoN Jan 13, 2024
2118a06
Update index.html
miketaylr Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,14 +1232,15 @@ <h2 id="automation">
<div class="algorithm">
<p>
To <dfn data-for="WebDriver">set a permission</dfn> given a {{PermissionDescriptor}}
|descriptor:PermissionDescriptor|, and a {{PermissionState}} |state:PermissionState|:
|descriptor:PermissionDescriptor|, a {{PermissionState}} |state:PermissionState|, and an
optional |origin|:
</p>
<ol>
<li>Let |settings| be the [=current settings object=].
<li>Let |target origin| be [=current settings object=]'s [=environment settings
object/origin=] if |origin| is null, or |origin| otherwise.
</li>
<li>Let |targets| be a <a>list</a> containing all [=environment settings objects=] whose
[=environment settings object/origin=] is [=same origin=] as the [=environment settings
object/origin=] of |settings|.
[=environment settings object/origin=] is [=same origin=] with |target origin|.
</li>
<li>Let |tasks| be an empty <a>list</a>.
</li>
Expand Down Expand Up @@ -1431,6 +1432,7 @@ <h6 id="webdriver-bidi-command-permissions-setPermission">
permissions.SetPermissionParameters = {
descriptor: permissions.PermissionDescriptor,
state: permissions.PermissionState,
origin: text,
}
</pre>
</dd>
Expand Down Expand Up @@ -1466,7 +1468,9 @@ <h6 id="webdriver-bidi-command-permissions-setPermission">
name|'s [=powerful feature/permission descriptor type=]. If this conversion
throws an exception, return [=error=] with [=error code=] [=invalid argument=].
</li>
<li>[=Set a permission=] with |typedDescriptor| and |state|.
<li>Let |origin| be the value of the `origin` field of |command parameters|.
</li>
<li>[=Set a permission=] with |typedDescriptor|, |state|, and |origin|.
</li>
<li>Return [=success=] with data `null`.
</li>
Expand Down
Loading