-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relatedResource
and digestSRI
to the vocabulary
#1296
Add relatedResource
and digestSRI
to the vocabulary
#1296
Conversation
- Added anchors to the `digestSRI` and `relatedResource` terms (to be used by the vocabulary - Added a section to define the `sristring` datatype - Added the `digestSRI`, `relatedResource`, `mediaType` to the v2 context - Added the `digestSRI` and `relatedResource` properties, as well as the `sristring` datatype to `vocabulary.yml` - Added a section on datatypes in the `template.html` file for the vocabulary generation - Added the `vocabulary.drawio` file to the repository and expanded the `README.md` file in the the corresponding directory T.B.D.: - Add the new terms to the diagram - Extend the diagram description to include the new terms.
…o-vocab * main: Add normative text requiring protecting VCs and VPs.
…rors) - `sristring` -> `sriString` - Generated previews for the vocabulary
Note: the SRI spec defines the integrity attribute in such a way that the attribute value can be a list of hash expressions (see Example 7 in the spec). By formally referring to those sections, the VCDM inherits this feature. I do not think that is a problem, I would rather think this is a feature, but I just wanted to draw attention to this fact. |
To be a bit picky about the RDFS aspects of the vocabulary: at the moment, the range of the I am happy to update the files if there is a consensus on this detail. Cc @pchampin |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also be happy if this used https://schema.org/CreativeWork.
The issue was discussed in a meeting on 2023-10-11
View the transcript1.9. Add
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Attempted to align
sriString
capitalization and URL. - Comments on vocab URL confusion. It seems like the vocab doc, spec, and context should be using strictly the same URL strings for identifiers. Or am I missing something there?
- Were the diagram object fill colors an accessibility problem?
Co-authored-by: David I. Lehn <[email protected]>
"digestSRI": { | ||
"@id": "https://www.w3.org/2018/credentials#digestSRI", | ||
"@type": "https://www.w3.org/2018/credentials#sriString" | ||
}, | ||
"mediaType": { | ||
"@id": "https://schema.org/encodingFormat" | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do we want both of these as top-level values... or do we want them under relatedResource
. I would imagine we'd want the latter? /cc @dlongley @davidlehn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msporny I am open either way, I leave the decision to you guys.
My argument for this setup is that digestSRI
might be useful elsewhere; there is nothing in the definition that is really bound to relatedResource
. After all, this is a general mechanism. (Note that the domain of digestSRI
is essentially open-ended, see also #1296 (comment)). But, again, I regard this as a VCDM domain issue, and I am not a VCDM expert, so to say...
Waiting on updates from @iherman to merge. |
@msporny made the changes; for further issues see #1296 (comment) and #1296 (comment). I have settled everything else.
For the latter: I leave you the decision. It is fine if you guys do the change on the context file if you decide to do so and then merge the PR. |
I'm going to merge this, pending the discussion on |
Normative, multiple reviews, changes requested and made, no objections, merging. |
This is the action I took at the F2F: adding the resource integrity terms to the VCDM vocabulary. Here is what I did:
digestSRI
andrelatedResource
terms in the specification itself (to be used by the vocabulary)sriString
datatypedigestSRI
,relatedResource
,mediaType
to the v2@context
filedigestSRI
andrelatedResource
properties, as well as thesriString
datatype, tovocabulary.yml
template.html
file for the vocabulary generationNote that the
mediaType
term has not been added to the vocabulary; instead, it is mapped to https://schema.org/encodingFormat term. Let us avoid the "not invented here" syndrome...Not strictly related to the underlying issue, but:
vocabulary.drawio
file to the repository and expanded theREADME.md
file in the corresponding directory (this makes the maintenance of the diagrams easier and puts the raw data into our repo)The automatic preview below works for the spec text, but not for the vocabulary. For the vocabulary files, see the separate vocabulary preview
This PR takes care of the issues #1237 and #1265.
Preview | Diff