Script execution: Throw error for invalid reference argument #1931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec, the window/frame/element/shadow root reference must be String.
However, current spec does not report error for this, even though there are tests created 2 years ago
https://github.com/web-platform-tests/wpt/blob/427276cdcaf28068aa1a2dae9206f03df716d367/webdriver/tests/classic/execute_async_script/arguments.py#L165-L167 for this.
This PR add the step to throw error if reference is not string.
Preview | Diff