Skip to content

Conversation

@yezhizhen
Copy link
Member

@yezhizhen yezhizhen commented Oct 18, 2025

According to spec, the window/frame/element/shadow root reference must be String.

  1. Let node id be a new globally unique string. (https://w3c.github.io/webdriver/#dfn-get-or-create-a-node-reference)
  2. Each browsing context has an associated window handle which uniquely identifies it. This must be a String and must not be "current".

However, current spec does not report error for this, even though there are tests created 2 years ago
https://github.com/web-platform-tests/wpt/blob/427276cdcaf28068aa1a2dae9206f03df716d367/webdriver/tests/classic/execute_async_script/arguments.py#L165-L167 for this.

This PR add the step to throw error if reference is not string.


Preview | Diff

@yezhizhen
Copy link
Member Author

cc @xiaochengh

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me. But there is a problem with the IPR check.

@yezhizhen you should probably join the group so that this wont be an issue in the future anymore.

@w3cbot
Copy link

w3cbot commented Oct 20, 2025

whimboo marked as non substantive for IPR from ash-nazg.

@whimboo whimboo merged commit 00a6484 into w3c:master Oct 20, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 20, 2025
…1931)

SHA: 00a6484
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to soloinovator/webdriver that referenced this pull request Oct 20, 2025
…3c#1931)

SHA: 00a6484
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to xjc90s/webdriver that referenced this pull request Oct 20, 2025
…3c#1931)

SHA: 00a6484
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yezhizhen yezhizhen deleted the patch-4 branch October 21, 2025 02:29
@yezhizhen
Copy link
Member Author

The changes look fine to me. But there is a problem with the IPR check.

@yezhizhen you should probably join the group so that this wont be an issue in the future anymore.

Thanks for inviting. I will try to clear some internal procedures required for it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants